Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix atom positions #153

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix atom positions #153

wants to merge 1 commit into from

Conversation

ndaelman-hu
Copy link
Contributor

Update the atomic positions extraction to also account for the new VASP 6 format (where 0.0768 is written as .0768)

Closes #152

@ndaelman-hu ndaelman-hu added the bug Something isn't working. It also represents a quick fix in response to a bug. label Aug 18, 2023
@ndaelman-hu ndaelman-hu requested a review from ladinesa August 18, 2023 15:14
@ndaelman-hu ndaelman-hu self-assigned this Aug 18, 2023
ladinesa
ladinesa reviewed Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@ladinesa ladinesa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we perhaps define a regex expression for float in vasp, something like ref_f = r'[-+]?\d*.\d(?:[Ee][-+]\d+)?' and use this throughout the code? It will make debugging a little easier. You can also not do it in this pr but please add a test for v6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladinesa ladinesa ladinesa left review comments

Assignees

@ndaelman-hu ndaelman-hu

Labels
bug Something isn't working. It also represents a quick fix in response to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VASP 6 format: fix atom positions
2 participants
@ndaelman-hu @ladinesa